Skip to content

[ENGA3-324]: Added Japanese translation for the error messages.#301

Merged
aashishgurung merged 1 commit into
masterfrom
feature/ENGA3-324
Sep 5, 2022
Merged

[ENGA3-324]: Added Japanese translation for the error messages.#301
aashishgurung merged 1 commit into
masterfrom
feature/ENGA3-324

Conversation

@aashishgurung
Copy link
Copy Markdown
Contributor

1. Objective

Add Japanese translation for the error messages due to invalid card info. Added some other missing translation as well.

Jira Ticket: #324

2. Description of change

  • Updated the translation files omise-ja.po and omise.mo with new Japanese traslation.
  • Updated the assets/javascripts/omise-payment-form-handler.js to converted the message received as API response to the Japanese language.
  • In includes/class-omise-wc-myaccount.php and includes/gateway/abstract-omise-payment-base-card.php, we added the required translation texts to the variable that needs to be passed to the JS file.

3. Quality assurance

First, change site language to Japanese. You can follow this link for assistance. Now, you must replace the omise-ja.po and omise-ja.mo present in the container's folder var/www/html/wp-content/languages/plugins. Assuming you are in the root of our omise-woocommerce plugin, use the following command to copy omise-ja.po and omise-mo inside docker container.

% docker cp languages/omise-ja.po <CONTAINER_ID>:/var/www/html/wp-content/languages/plugins
% docker cp languages/omise-ja.mo <CONTAINER_ID>:/var/www/html/wp-content/languages/plugins

🔧 Environments:

  • WooCommerce: v6.8.0
  • WordPress: v6.0.1
  • PHP version: 8.1
  • Omise plugin version: Omise-WooCommerce 4.23.2

… due to invalid card info. Added some other missing translation as well.
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aashishgurung aashishgurung changed the title [ENA3-324]: Added Japanese translation for the error messages. [ENGA3-324]: Added Japanese translation for the error messages. Aug 31, 2022
@aashishgurung aashishgurung merged commit f049b26 into master Sep 5, 2022
@aashishgurung aashishgurung deleted the feature/ENGA3-324 branch September 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants