Support for gateways without default option format#33
Merged
Conversation
Added support for WooCommerce payment gateways (like Mollie Payments for WooCommerce) that use another format for option names, and no 'woocommerce_' prefix. Also, see TODO and please consider adding a warning/notice + stop function execution if the $options variable stays false. That would solve all future fatal errors for gateways with yet again another format.
Owner
|
@davdebcom Thanks, but you have broken it down for validation and saving. Could you retest it with my update? It's working fine with "normal" WC payment methods, just want to double check that I haven't broked it for yours. Please verify as well saving the correct options when clicked. I have updated the code and added an admin notice error as you proposed, thanks. |
vyskoczilova
added a commit
that referenced
this pull request
Feb 10, 2018
Contributor
Author
|
Works for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for WooCommerce payment gateways (like Mollie Payments for WooCommerce) that use another format for option names, and no 'woocommerce_' prefix. Also, see TODO and please consider adding a warning/notice + stop function execution if the $options variable stays false. That would solve all future fatal errors for gateways with yet again another format.